Skip to content

ci: make codecov patch status informational#1616

Open
zimeg wants to merge 1 commit into
mainfrom
ci/codecov-patch-informational
Open

ci: make codecov patch status informational#1616
zimeg wants to merge 1 commit into
mainfrom
ci/codecov-patch-informational

Conversation

@zimeg

@zimeg zimeg commented Jun 30, 2026

Copy link
Copy Markdown
Member

This pull request makes the Codecov patch status informational so it no longer shows a misleading failing "x".

  • Previously patch.default used target: 30%, so any PR with 0% diff coverage (e.g. docs- or config-only changes with no measurable lines) failed the patch check even when nothing testable changed.
  • informational: true keeps the patch coverage percentage visible on the PR but never blocks or reports a failing status.
  • The project status is unchanged.

Preview

Before changes we find confusion in commit statuses despite passing tests:

codecov

After this change we might prefer to use @codecov comments and reviews

Category

  • CI

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

The patch status had target: 30%, so PRs with 0% diff coverage (e.g.
docs- or config-only changes with no measurable lines) failed with a
misleading red "x" even when nothing testable changed. Marking the patch
status informational keeps the coverage percentage visible on the PR
without ever blocking or reporting a failing status.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg zimeg added github_actions Pull requests that update GitHub Actions code semver:patch labels Jun 30, 2026
@zimeg zimeg self-assigned this Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.30%. Comparing base (a312395) to head (678d1d3).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1616      +/-   ##
============================================
- Coverage     73.32%   73.30%   -0.03%     
+ Complexity     4520     4518       -2     
============================================
  Files           478      478              
  Lines         14300    14300              
  Branches       1490     1490              
============================================
- Hits          10486    10483       -3     
- Misses         2923     2925       +2     
- Partials        891      892       +1     
Flag Coverage Δ
jdk-14 73.30% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@zimeg zimeg marked this pull request as ready for review June 30, 2026 08:27
@zimeg zimeg requested a review from a team as a code owner June 30, 2026 08:27

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving a comment of reference for the most wonderful readers 🤓

Comment thread codecov.yml
patch:
default:
target: 30%
informational: true

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants